feat: coin control to exchange/swap send flow - #1374
Draft
sneurlax wants to merge 2 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #1374 +/- ##
===========================================
- Coverage 4.84% 4.83% -0.01%
===========================================
Files 1092 1092
Lines 109141 109230 +89
===========================================
Hits 5283 5283
- Misses 103858 103947 +89 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Converting to draft because I have too many open PRs ready--will take another review pass over this before re-readying it |
sneurlax
marked this pull request as draft
August 20, 2026 18:58
The dialog popped itself on Cancel, but twelve of its thirteen call sites already popped in their own onCancel handler, so on mobile Cancel tore down the dialog and the page behind it. Dismissal now belongs to the caller, and the exchange step 4 send flow gains the pop it had been relying on the dialog for.
Adds a "Coin control" row to the mobile exchange step 4 send button and to each wallet card in the send-from view, backed by a shared module: a visibility predicate, an amount-plus-fee funding estimate computed at the same rate the send will use, and a validator that re-reads every stored output from the database before opening the picker and again before sending. Outputs that went missing, changed wallet, were frozen, spent or lost their confirmations clear the selection; a merely underfunded one is kept so the user can add more. Firo is excluded.
sneurlax
force-pushed
the
feat/404-coin-control-swaps
branch
from
August 24, 2026 21:31
4bf149f to
43528a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #404